Skip to content

Support hidden visibility for compatibility with webR #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennybc merged 2 commits into from
Nov 18, 2022
Merged

Support hidden visibility for compatibility with webR #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da0bd64
Support hidden visibility
lionel- Nov 17, 2022
fa94a58
Add NEWS bullet
jennybc Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# glue (development version)

* Add `$(C_VISIBILITY)` to compiler flags to hide internal symbols from the dll (#284 @lionel-).

# glue 1.6.2

* Modify a test for better forward compatibility with R.
Expand Down
1 change: 1 addition & 0 deletions src/Makevars
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PKG_CFLAGS = $(C_VISIBILITY)
6 changes: 6 additions & 0 deletions src/init.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
#include <Rinternals.h>
#include <stdlib.h> // for NULL

// Compile with `C_VISIBILITY = -fvisibility=hidden` if you link to
// this library
#include <R_ext/Visibility.h>
#define export attribute_visible extern

/* .Call calls */
extern SEXP glue_(SEXP, SEXP, SEXP, SEXP, SEXP, SEXP);
extern SEXP trim_(SEXP);
Expand All @@ -12,6 +17,7 @@ static const R_CallMethodDef CallEntries[] = {
{"trim_", (DL_FUNC)&trim_, 1},
{NULL, NULL, 0}};

export
void R_init_glue(DllInfo* dll) {
R_registerRoutines(dll, NULL, CallEntries, NULL, NULL);
R_useDynamicSymbols(dll, FALSE);
Expand Down