Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a small API/UX cleanup across the core Tool/Workflow write + metadata flow, updates schema-visualization naming, and introduces a new schema validation helper (nemo_schema_check) to validate schema.yaml structure and conventions.
Changes:
- Make
input_id/output_idoptional inTool$write()andWorkflow$write(), and include the raw input file path (raw_path) in write results for metadata. - Adjust workflow metadata behavior: add
metapkgto control which package(s) are version-reported, and write metadata into an_metadata/metadata.jsonsubdirectory. - Add
nemo_schema_check()and renamenemo_schema_data()→nemo_schemavis_data()across code/docs/tests.
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
vignettes/fig/uml/nemo.uml |
Removes PlantUML source from vignettes UML assets. |
vignettes/fig/uml/nemo.svg |
Removes generated SVG UML diagram from vignettes UML assets. |
tests/testthat/test-roxytest-testexamples-schema_vis.R |
Updates generated roxytest expectations for renamed schema-vis data function. |
tests/testthat/test-roxytest-testexamples-schema_check.R |
Adds generated roxytest coverage for new nemo_schema_check(). |
R/Workflow.R |
Adds metapkg, updates printing, makes IDs optional, writes metadata under _metadata/, and adjusts metadata file manifest fields. |
R/Tool.R |
Makes IDs optional in write(), adds raw_path to write output, and updates list_files documentation wording. |
R/schema_vis.R |
Renames nemo_schema_data() to nemo_schemavis_data() and updates reactable helper usage. |
R/schema_check.R |
Introduces new schema validation function and internal checker. |
R/metadata.R |
Updates metadata title/fields and loosens type checks for optional IDs. |
NAMESPACE |
Exports new nemo_schema_check and renamed nemo_schemavis_data; drops export of old name. |
man/Workflow.Rd |
Documents new metapkg, optional output_id, and updated list_files description. |
man/Tool.Rd |
Documents optional output_id and updated list_files description. |
man/reactable_schema.Rd |
Updates example to call nemo_schemavis_data(). |
man/nemo_schemavis_data.Rd |
Updates generated Rd for renamed schema-vis data function. |
man/nemo_schema_check.Rd |
Adds generated Rd for new schema check function. |
man/nemo_metadata.Rd |
Updates title/description for metadata helper. |
.claude/CLAUDE.md |
Refreshes contributor guidance and the API reference table (but still contains an outdated function name reference). |
Files not reviewed (5)
- man/Tool.Rd: Language not supported
- man/Workflow.Rd: Language not supported
- man/nemo_metadata.Rd: Language not supported
- man/nemo_schema_check.Rd: Language not supported
- man/reactable_schema.Rd: Language not supported
Comments suppressed due to low confidence (1)
R/Tool.R:577
Tool$write()now returns araw_pathcolumn, but the method’s return-value documentation (and any roxytest expectations generated from it) still describe the old column set. Update the roxygen/Rd docs (and any@testexamplesthat assert the column names) to includeraw_pathso the public API remains accurate.
dplyr::select(
"raw_path",
"tool_parser",
"prefix",
"tidy_data",
"tbl_name",
"outpath"
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input_id,output_idoptionalwriteresult, for use within metadatametapkgfield for specifying pkgs for metadata versioninginput_id,output_idoptional_metadata/metadata.jsonnownemo_schema_check(converted this to a function from a Claude skill, want to build on top of this at some point)nemo_schema_data->nemo_schemavis_datafor clarity