feat(deploy_to_autoware): rework metadata script#36
Conversation
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
scepter914
left a comment
There was a problem hiding this comment.
Thank you for contribution 👍
I'm planning to set up a pipeline for deployment from now on, so I intend to use this script. Really appreciate it.
|
@scepter914 |
|
Hi @amadeuszsz Just a question, is it better if we make the code more object-oriented, and each project only uses the class in their own deployment script? In this way, we can set up metadata for different projects |
|
@KSeangTan
Method 2 (the approach proposed by Kok-san): Is that correct? Technically, either method is feasible. For example, with Method 2, if the class is modified, all the ONNX generation scripts in each project would also need to be updated. Of course, if a project requires embedding some special metadata during deployment, it’s certainly possible to prepare a project-specific script. |
I like this idea! If we have much more shared features, we could go for a design of AWModel meta class and make it standard for all AWML projects. |
|
Yes, you are right that the method 1 is better in maintainability, and it also looks good to me. I suppose we can think about the shared metadata design that will not be changed for a long time, and every project uses that |
Summary
An update for metadata info script.
Change point
Latest PR just added script without deeper investigation. This PR refines meta information settings in order to achieve an appropriate logging during Autoware runtime.
Note
Domain field refers to ONNX operator set, not task type. So far we use default operator set, therefore
ai.onnxis the only choice (see https://github.com/onnx/onnx/blob/main/docs/Versioning.md#released-versions).Test performed