Skip to content

feat(stop_accel_evaluator): use flexible lpf#3

Merged
yabuta merged 2 commits intotier4/universefrom
feat/apply-flexible-lpf
Jul 29, 2022
Merged

feat(stop_accel_evaluator): use flexible lpf#3
yabuta merged 2 commits intotier4/universefrom
feat/apply-flexible-lpf

Conversation

@takayuki5168
Copy link
Copy Markdown
Contributor

@takayuki5168 takayuki5168 commented Jul 7, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

PR Type

  • Improvement

Related Links

Description

To align with autowarefoundation/autoware_universe#1135

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 requested a review from yabuta July 7, 2022 01:07
@yabuta
Copy link
Copy Markdown
Collaborator

yabuta commented Jul 28, 2022

@takayuki5168
Change looks good.
Do you know why the build-and-test-differential / build-and-test-differential (galactic) (pull_request) error is happening?

Copy link
Copy Markdown
Collaborator

@yabuta yabuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168
Copy link
Copy Markdown
Contributor Author

@yabuta
Do you know why pre-commit, which is required to merge this PR, was skipped? This happens in another PR.
I'm not sure, but github actions setting of pre-commit may be incorrect?

image

@yabuta
Copy link
Copy Markdown
Collaborator

yabuta commented Jul 29, 2022

Sorry, I dont know.
Perhaps, Change is too shorts?

@takayuki5168
Copy link
Copy Markdown
Contributor Author

@yabuta Sorry, I thought the skipped pre-commit has to pass in order to merge this PR.
Please merge the PR when you want to.

@yabuta yabuta merged commit e5a9117 into tier4/universe Jul 29, 2022
@wep21 wep21 deleted the feat/apply-flexible-lpf branch August 30, 2022 20:30
aohsato pushed a commit that referenced this pull request Jun 6, 2023
feat(launch): new perception launch system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants