fix(deviation_estimation_tools): fix a bug in loading parameter file#8
Merged
kminoda merged 4 commits intotier4/universefrom Jul 8, 2022
Merged
Conversation
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
YamatoAndo
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kminoda koji.m.minoda@gmail.com
Description
The format of the parameter file for
deviation_evaluatorwas broken.I have also changed the name of the parameter file (
*.yaml->*.param.yaml) to follow the naming rules of the other config files in Autoware.Related links
Tests performed
I modified some parameters in
deviation_evaluator.param.yamland verified that is reflected byros2 param get /deviation_evaluator PARAM_NAME.Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.