Skip to content

fix(deviation_estimation_tools): fix a bug in loading parameter file#8

Merged
kminoda merged 4 commits intotier4/universefrom
fix/deviation_estimation_tools_param_loading
Jul 8, 2022
Merged

fix(deviation_estimation_tools): fix a bug in loading parameter file#8
kminoda merged 4 commits intotier4/universefrom
fix/deviation_estimation_tools_param_loading

Conversation

@kminoda
Copy link
Copy Markdown
Contributor

@kminoda kminoda commented Jul 8, 2022

Signed-off-by: kminoda koji.m.minoda@gmail.com

Description

The format of the parameter file for deviation_evaluator was broken.
I have also changed the name of the parameter file (*.yaml -> *.param.yaml) to follow the naming rules of the other config files in Autoware.

Related links

Tests performed

I modified some parameters in deviation_evaluator.param.yaml and verified that is reflected by ros2 param get /deviation_evaluator PARAM_NAME .

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda added 4 commits July 8, 2022 11:44
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda kminoda requested a review from YamatoAndo July 8, 2022 02:55
@kminoda kminoda merged commit 1430972 into tier4/universe Jul 8, 2022
@kminoda kminoda deleted the fix/deviation_estimation_tools_param_loading branch November 30, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants