fix(virtio): read notify_off_multiplier correctly#505
Merged
Conversation
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Koichi98
approved these changes
Jun 16, 2025
ytakano
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current implementation on how to get
notify_off_multiplieris incorrect.virtio_pci_notify_capis an extention ofvirtio_pci_cap, andnotify_off_multipliershould be read soon aftervirtio_pci_notify_capis found.Related links
VirtIO Specification 4.1.4.4 Notification structure layout
https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-2510003:~:text=4.1.4.4%20Notification%20structure%20layout
OpenBSD
notify_off_multiplierhttps://github.com/openbsd/src/blob/b38eaba60654ec6b523c64ac5243d89896ee0b6c/sys/dev/pci/virtio_pci.c#L510
How was this PR tested?
Tested in #465
Notes for reviewers