Skip to content

fix(virtio): read notify_off_multiplier correctly#505

Merged
ytakano merged 2 commits intomainfrom
fix/virtio_notify_cng
Jun 16, 2025
Merged

fix(virtio): read notify_off_multiplier correctly#505
ytakano merged 2 commits intomainfrom
fix/virtio_notify_cng

Conversation

@veqcc
Copy link
Copy Markdown
Contributor

@veqcc veqcc commented Jun 16, 2025

Description

Current implementation on how to get notify_off_multiplier is incorrect.
virtio_pci_notify_cap is an extention of virtio_pci_cap, and notify_off_multiplier should be read soon after virtio_pci_notify_cap is found.

struct virtio_pci_notify_cap { 
        struct virtio_pci_cap cap; 
        le32 notify_off_multiplier; /* Multiplier for queue_notify_off. */ 
};

Related links

VirtIO Specification 4.1.4.4 Notification structure layout
https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-2510003:~:text=4.1.4.4%20Notification%20structure%20layout

OpenBSD notify_off_multiplier
https://github.com/openbsd/src/blob/b38eaba60654ec6b523c64ac5243d89896ee0b6c/sys/dev/pci/virtio_pci.c#L510

How was this PR tested?

Tested in #465

Notes for reviewers

veqcc added 2 commits June 16, 2025 15:42
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc requested review from Koichi98 and ytakano June 16, 2025 06:55
@veqcc veqcc self-assigned this Jun 16, 2025
@ytakano ytakano merged commit 319994a into main Jun 16, 2025
1 check passed
@ytakano ytakano deleted the fix/virtio_notify_cng branch June 16, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants