Conversation
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
ytakano
approved these changes
Jun 17, 2025
Koichi98
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
speed=1000,duplex=fullinQEMU_X86_NET_ARGSso that virtio-net driver can get speed and duplex infomation from net-config space.Changed
link_speed()andlink_speed()to get the actual values from configuration spaces.Related links
ViotIO Specification
5.1.4 Device configuration layouthttps://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-1220001:~:text=The%20following%20two%20fields,for%20unknown%20duplex%20state.
OpenBSD does not have similar functionality.
FreeBSD have one, but not completely the same: https://github.com/freebsd/freebsd-src/blob/6039cd1b45eb847ef5bbe6c58341b8b92fff8a74/sys/dev/virtio/network/if_vtnet.c#L3934
How was this PR tested?
Tested in #465
Notes for reviewers
I am not sure what to return when speed/duplex could not obtained.