Skip to content

Comments

fix(pubsub): lost wakeup#656

Merged
ytakano merged 4 commits intomainfrom
fix_pubsub_lostwakeup
Oct 9, 2025
Merged

fix(pubsub): lost wakeup#656
ytakano merged 4 commits intomainfrom
fix_pubsub_lostwakeup

Conversation

@kobayu858
Copy link
Contributor

@kobayu858 kobayu858 commented Oct 6, 2025

Description

This commit fixes a "Lost Wakeup" race condition in the asynchronous Pub/Sub implementation.

Related links

Lost wakeup
Fix result

How was this PR tested?

  • Test application (rd_gen_to_dag). Result is in related links.

Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
@atsushi421 atsushi421 self-requested a review October 7, 2025 04:36
atsushi421
atsushi421 previously approved these changes Oct 7, 2025
Copy link
Contributor

@atsushi421 atsushi421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atsushi421 atsushi421 dismissed their stale review October 7, 2025 05:31

Sorry, I made another comment.

@atsushi421 atsushi421 self-requested a review October 7, 2025 05:32
Signed-off-by: kobayu858 <yutaro.kobayashi.2@tier4.jp>
@ytakano ytakano merged commit 8d34229 into main Oct 9, 2025
1 check passed
@ytakano ytakano deleted the fix_pubsub_lostwakeup branch October 9, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants