feat(igc): add on-demand netdump observability#685
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an on-demand network device “netdump” observability path by introducing a NetDevice::debug_dump() hook, exposing it via awkernel_lib::net::debug_dump_interface(), and wiring it into the Awkernel shell as (netdump interface_id).
Changes:
- Add a default
debug_dump()method to theNetDevicetrait. - Add
awkernel_lib::net::debug_dump_interface(interface_id)to trigger a device dump for a specific interface. - Add a
netdumpshell command and FFI plumbing (with new bigint conversion deps) to invoke the interface dump.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
awkernel_lib/src/net/net_device.rs |
Introduces a default NetDevice::debug_dump() hook. |
awkernel_lib/src/net.rs |
Adds debug_dump_interface() entry point in the net manager layer. |
awkernel_drivers/src/pcie/intel/igc.rs |
Wires Igc’s NetDevice::debug_dump() to existing inner dump logic. |
applications/awkernel_shell/src/lib.rs |
Adds (netdump interface_id) BLisp export and embedded FFI handler. |
applications/awkernel_shell/Cargo.toml |
Adds num-bigint / num-traits dependencies for the new FFI argument type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Clone the selected network device while holding the net manager read lock, then release the lock before invoking the debug dump path. This keeps potentially slow diagnostic dumping outside the shared manager lock and matches the existing interface operation pattern.
atsushi421
reviewed
Apr 27, 2026
Signed-off-by: Yuuki Takano <ytakanoster@gmail.com>
atsushi421
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds on-demand IGC observability without changing datapath behavior.
It introduces a default NetDevice::debug_dump() hook, adds awkernel_lib::net::debug_dump_interface(), and wires the shell netdump(interface_id) command to the IGC driver’s existing register and ring dump logic
Related links
How was this PR tested?
Notes for reviewers
This PR is intentionally limited to read-only observability. It does not change queueing, DMA, interrupt handling, or RX buffering behavior.
The shell addition is only netdump(interface_id). Write-path helpers such as add_ipv4, arping4, and set_gateway4 are not included here.