build: fix protobuf gencode vs. runtime version conflict#40
Conversation
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
|
@Owen-Liuyuxuan Could I have your opinion on this approach? It's the simplest one I found that passes CI, and guarantees correct versions in the |
|
@mojomex Does it work? I saw there are 6.33.5 in build system and 6.33.6 in the uv lock. |
|
@Owen-Liuyuxuan I don't have time to try in Pilot Auto CI 🙇 , but CI here succeeds. 6.33.4 has a security vulnerability, so I moved everything to 6.33.5 instead. See https://github.com/tier4/sync_tooling/security/dependabot/15 |
|
@mojomex |
|
@mojomex I got it, so the run time is running with 6.33.6 and the gencode is 6.33.5 now. In this case it is working. Thank you. https://protobuf.dev/support/cross-version-runtime-guarantee/ cc: @KYabuuchi taught me that runtime > gencode is OK |
|
Thank you @Owen-Liuyuxuan for approving, and @KYabuuchi for the evaluator build 🥇 I'll await the results from it, and if OK, merge and create a new version. Thank you for your patience. |
KYabuuchi
left a comment
There was a problem hiding this comment.
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
|





This PR updates sync_tooling_msgs to a version that locks the build-time
protobufdependency to6.33.5and the runtime version to>=6.33.5,<7to avoid protobufgencodevsruntimeversion conflicts.See Protobuf Docs: Cross-Version Runtime Guarantee for details on allowed version combinations. Most relevant:
So, ensure that
build-system.requirescontainsprotobuf==6.33.5and runtime (normal dependencies) containsprotobuf>=that.So, limit runtime deps to
protobuf<7, resulting in a combinedprotobuf>=6.33.5,<7.Corresponding
sync_tooling_msgsPR: