Skip to content

feat(viewer): add an option whether to render map#278

Merged
ktro2828 merged 1 commit into
mainfrom
feat/disable-map-render
Jun 2, 2026
Merged

feat(viewer): add an option whether to render map#278
ktro2828 merged 1 commit into
mainfrom
feat/disable-map-render

Conversation

@ktro2828
Copy link
Copy Markdown
Collaborator

@ktro2828 ktro2828 commented Jun 2, 2026

What

This pull request adds a new feature to the visualization CLI and rendering pipeline that allows users to optionally render the map in scene, instance, and pointcloud visualizations. The change introduces a --map (-m) command-line flag to the relevant CLI commands and propagates the show_map parameter through the codebase to control map rendering.

To improve the rendering speed, show_map=False by defaults.

The most important changes are:

CLI Enhancements:

  • Added a --map (-m) boolean option to the scene, instance, and pointcloud commands in t4_devkit/cli/visualize.py to allow users to specify whether to render the map. [1] [2] [3]

Rendering Pipeline Updates:

  • Updated the render_scene, render_instance, and render_pointcloud methods in t4_devkit/helper/rendering.py and t4_devkit/tier4.py to accept and propagate the show_map parameter, including updating docstrings to document the new argument. [1] [2] [3] [4] [5] [6] [7]

Rendering Logic:

  • Modified the rendering logic in t4_devkit/helper/rendering.py to conditionally call the map rendering function (_try_render_map) when show_map is True for all three visualization modes. [1] [2] [3]

These changes collectively enable users to control map rendering in visualizations via a simple CLI flag, improving flexibility and usability.

@ktro2828 ktro2828 requested a review from Copilot June 2, 2026 05:28
@github-actions github-actions Bot added the new-feature New feature or request label Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

☂️ Python Coverage

current status: ❌

Overall Coverage

Lines Covered Coverage Threshold Status
4228 3496 83% 50% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
t4_devkit/helper/rendering.py 17% 🔴
t4_devkit/tier4.py 83% 🟢
TOTAL 50% 🔴

updated for commit: 1bcb2e0 by action🐍

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a user-configurable switch for rendering the vector map in the visualization CLI (t4viz) and propagates that choice through T4Devkit into the rendering helper so map rendering can be toggled for scene, instance, and pointcloud visualizations.

Changes:

  • Added a --map (-m) flag to t4viz scene|instance|pointcloud and passed the value into the rendering calls.
  • Introduced a render_map parameter on T4Devkit.render_scene/render_instance/render_pointcloud and on the corresponding RenderingHelper methods.
  • Made map rendering conditional (_try_render_map) based on render_map.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File Description
t4_devkit/cli/visualize.py Adds CLI flag to control whether map rendering is enabled and forwards it to the API.
t4_devkit/helper/rendering.py Threads render_map into rendering entrypoints and gates _try_render_map behind it.
t4_devkit/tier4.py Exposes render_map on the public T4Devkit render methods and forwards to helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread t4_devkit/helper/rendering.py
Comment thread t4_devkit/helper/rendering.py
Comment thread t4_devkit/helper/rendering.py
Comment thread t4_devkit/tier4.py
Comment thread t4_devkit/tier4.py
Comment thread t4_devkit/tier4.py
Comment thread t4_devkit/cli/visualize.py Outdated
Comment thread t4_devkit/cli/visualize.py Outdated
Comment thread t4_devkit/cli/visualize.py Outdated
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the feat/disable-map-render branch from a03d6bf to 1bcb2e0 Compare June 2, 2026 05:43
@ktro2828 ktro2828 merged commit 8403461 into main Jun 2, 2026
5 checks passed
@ktro2828 ktro2828 deleted the feat/disable-map-render branch June 2, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants