Replace .sln with .slnx; drop IDE-template scaffolding#3
Open
andyleejordan wants to merge 1 commit intotig:terminal_gui_v2from
Open
Replace .sln with .slnx; drop IDE-template scaffolding#3andyleejordan wants to merge 1 commit intotig:terminal_gui_v2from
andyleejordan wants to merge 1 commit intotig:terminal_gui_v2from
Conversation
The tracked GraphicalTools.sln carried stale ProjectReferences to
local Terminal.Gui sources, breaking CI's `dotnet test` (which was
implicitly resolving the solution). Switch to the modern .slnx format
and track it directly so the solution is reviewable and small.
- Replace GraphicalTools.sln with GraphicalTools.slnx (5-line XML;
lists the 3 real projects, no dead Terminal.Gui ProjectReferences)
- Stop ignoring .slnx and .vscode/; track them
- Remove tools/initDevEnvironment.ps1 and tools/ide/ — no longer
needed; .slnx is small enough to track and VS Code workspace
files are now the supported way to share dev config
- Add .vscode/{launch,tasks,extensions}.json:
* launch.json: single coreclr profile with a pickString input for
selecting one of the OCGV / Show-ObjectTree sample commands
* tasks.json: build (Invoke-Build), test (zero-arg dotnet test
auto-resolves the .slnx), clean
* extensions.json: recommends C# Dev Kit + PowerShell
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Hey @tig I fixed the CI and cleaned up the dev stuff, you can merge that to your branch to update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets your PR PowerShell#267 (PowerShell/ConsoleGuiTools).
Why
CI on PowerShell#267 was failing in the
Testtask because the trackedGraphicalTools.slnhad staleProjectReferences to local Terminal.Gui sources at..\gui-cs\Terminal.Gui\...that don't exist on the runner.dotnet test(with no explicit path) resolved that solution and blew up withMSB3202: project file ... was not found.Rather than just removing the dead refs, this modernizes the setup:
What
GraphicalTools.slnwithGraphicalTools.slnx— 5-line declarative XML, no GUIDs, no platform/config matrix. Trivially reviewable; stale references like the Terminal.Gui ones become obvious in diff..slnxand.vscode/— removed the broad ignores. The whole point of.slnxis that it's small enough to live in source control.tools/initDevEnvironment.ps1+tools/ide/— no longer needed. The script existed to regenerate a per-developer.sln(because.slns were ignored). With.slnxtracked, devs just clone and go. VS Code workspace files now come from.vscode/directly, which is the supported way to share dev config..vscode/{launch,tasks,extensions}.json:launch.json: onecoreclrdebug profile with apickStringinput that prompts for which OCGV / Show-ObjectTree sample to run after importing the freshly built module. Adding new scenarios = appending one line.tasks.json:build(Invoke-Build Build),test(zero-argdotnet test— auto-resolves.slnx),clean.extensions.json: recommends C# Dev Kit + C# + PowerShell.ConsoleGuiTools.build.ps1Test task: kept as plaindotnet test— works correctly now that the bad.slnis gone (auto-resolves.slnx).Verified locally
dotnet build GraphicalTools.slnx— cleandotnet test(zero-arg) — 73/73 passingInvoke-Build Build, Test— greenThis should unblock CI on PowerShell#267.