Skip to content

Comments

GH#1906: Update storage provisioners#1908

Merged
ctauchen merged 1 commit intotigera:mainfrom
ctauchen:azure-disk
Apr 8, 2025
Merged

GH#1906: Update storage provisioners#1908
ctauchen merged 1 commit intotigera:mainfrom
ctauchen:azure-disk

Conversation

@ctauchen
Copy link
Collaborator

@ctauchen ctauchen commented Feb 14, 2025

The in-tree provisioners were migrated to external providers. They are
now all deprecated or removed.

This commit replaces the old in-tree values with their external
counterparts.

Resolves #1906

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@ctauchen ctauchen requested a review from a team as a code owner February 14, 2025 10:17
@netlify
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 06c5c19
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/67c19f876f003c00085b5048
😎 Deploy Preview https://deploy-preview-1908--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 06c5c19
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/67c19f872a36550008d3d577
😎 Deploy Preview https://deploy-preview-1908--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28 (🟢 up 2 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen ctauchen changed the title Update Azure storage provisioner GH#1906: Update Azure storage provisioner Feb 14, 2025
kind: StorageClass
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctauchen I think other kubernetes.io-prefixed provisioners are deprecated too, not just kubernetes.io/azure-disk? there are more such occurences, such as kubernetes.io/aws-ebs and kubernetes.io/gce-pd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see e.g. this document from AWS

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've updated aws-ebs and gce-pd. I can't find anything else, though I am concerned that these external provisioners may require additional steps. Do they need to be separately installed? @moredatapls

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctauchen I am not sure about AWS and GCP but on AKS the providers do have to be activated while provisioning a cluster, see e.g. here: https://learn.microsoft.com/en-us/azure/aks/csi-storage-drivers#enable-csi-storage-drivers-on-an-existing-cluster

@ctauchen ctauchen changed the title GH#1906: Update Azure storage provisioner GH#1906: Update storage provisioners Feb 28, 2025
metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: provisioner: ebs.csi.aws.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
provisioner: provisioner: ebs.csi.aws.com
provisioner: ebs.csi.aws.com

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all fixed now.

The in-tree provisioners were migrated to external providers. They are
now all deprecated or removed.

This commit replaces the old in-tree values with their external
counterparts.

Resolves GH#1906
name: tigera-elasticsearch
provisioner: kubernetes.io/azure-disk
provisioner: disk.cni.azure.com
parameters:
Copy link

@moredatapls moredatapls Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We performed this migration last week and it turns out that the new provisioners also have a different parameter syntax. The available parameters for disk.cni.azure.com are listed here

The Azure parameters block should look as follows, I believe:

parameters:
  cachingMode: ReadOnly
  skuName: StandardSSD_LRS

I am not sure about GCP and AWS, though

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my other comments regarding GKE and EBS

metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/gce-pd
provisioner: pd.csi.storage.gke.io

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the GKE parameters look correct, see here

metadata:
name: tigera-elasticsearch
provisioner: kubernetes.io/aws-ebs
provisioner: ebs.csi.aws.com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the EBS parameters are listed here

They would have to be changed as follows, I believe:

parameters:
  type: gp2
  "csi.storage.k8s.io/fstype": ext4

@ctauchen ctauchen merged commit 1285e8b into tigera:main Apr 8, 2025
10 checks passed
@moredatapls
Copy link

@ctauchen you merged the PR but I left some comments regarding the parameters, from what I can tell the examples in the docs are not functional with your changes

@ctauchen ctauchen deleted the azure-disk branch January 26, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The create-storage page should not use deprecated provisioners

3 participants