Skip to content

[v1.37] fix github release failing due to missing binary#3795

Merged
marvin-tigera merged 1 commit intotigera:release-v1.37from
radTuti:github-release-1.37
Feb 27, 2025
Merged

[v1.37] fix github release failing due to missing binary#3795
marvin-tigera merged 1 commit intotigera:release-v1.37from
radTuti:github-release-1.37

Conversation

@radTuti
Copy link
Copy Markdown
Contributor

@radTuti radTuti commented Feb 27, 2025

Description

this happens because it depends on release-notes target which calls clean that cleans up the bin

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@radTuti
fix github release failing due to missing binary
aebd112 
this happens because it depends on `release-notes` target which calls `clean` that cleans up the bin
@radTuti radTuti requested a review from a team as a code owner February 27, 2025 15:54
@marvin-tigera marvin-tigera added this to the v1.37.2 milestone Feb 27, 2025
@marvin-tigera marvin-tigera merged commit bd6c640 into tigera:release-v1.37 Feb 27, 2025
2 checks passed
@radTuti radTuti deleted the github-release-1.37 branch March 28, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danudey danudey danudey approved these changes

Assignees

No one assigned

Labels

docs-not-required merge-when-ready release-note-not-required

Projects

None yet

Milestone

v1.37.2

Development

Successfully merging this pull request may close these issues.

3 participants

@radTuti @danudey @marvin-tigera