fix(istio): Register NetworkAttachmentDefinition type in operator scheme#4408
Merged
electricjesus merged 2 commits intomasterfrom Feb 6, 2026
Merged
Conversation
Member
These feels like the main problem? We should just be registering the type and not using |
caseydavenport
requested changes
Feb 6, 2026
Member
caseydavenport
left a comment
caseydavenport
left a comment
There was a problem hiding this comment.
I think we should just register the NAD with our scheme instead of relying on unstructured, and avoid the changes here.
Register the k8s.cni.cncf.io/v1 NetworkAttachmentDefinition type in the operator's scheme so the Istio Helm chart deserializer can decode it as a typed object. This replaces the unstructured.Unstructured fallback from #4402, avoiding ObjectMetaAccessor compatibility issues downstream.
electricjesus
force-pushed
the
seth/fix-objectmetaaccessor-unstructured
branch
from
e260cdc to
492c80d
Compare
electricjesus
changed the title
caseydavenport
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the
NetworkAttachmentDefinitiontype (k8s.cni.cncf.io/v1) in the operator scheme so the Istio Helm chart manifests on OpenShift are decoded as typed objects instead of falling back to unstructured.Picks: #4405 (release-v1.40), #4406 (release-v1.41)