fix(tier cleanup): Deprecated tier cannot be deleted#4480
Merged
rene-dekker merged 2 commits intotigera:masterfrom Mar 3, 2026
Merged
fix(tier cleanup): Deprecated tier cannot be deleted#4480rene-dekker merged 2 commits intotigera:masterfrom
rene-dekker merged 2 commits intotigera:masterfrom
Conversation
radixo
reviewed
Feb 27, 2026
Comment on lines
1490
to
1494
| // allow-tigera Tier was renamed to calico-system | ||
| objs = append(objs, | ||
| networkpolicy.DeprecatedAllowTigeraNetworkPolicyObject("manager-access", installNS), | ||
| networkpolicy.DeprecatedAllowTigeraNetworkPolicyObject("default-deny", installNS), | ||
| ) |
Contributor
There was a problem hiding this comment.
Should we keep this one? Did I do right using installNS?
Member
Author
There was a problem hiding this comment.
Due to manager being moved to another namespace in the previous release, there can be a network policy for 2 namespaces in the old tier.
The manager controller did not clean up deprecated policies, due to trying to delete them from the wrong namespace. As a result, the old tier (allow-tigera) can never be deleted.
The manager controller did not clean up deprecated policies, due to trying to delete them from the wrong namespace. As a result, the old tier (allow-tigera) can never be deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manager controller did not clean up deprecated policies, due to trying to delete them from the wrong namespace. As a result, the old tier (allow-tigera) can never be deleted.