Fix sync-versions GHA for older release branches#4545
Merged
caseydavenport merged 1 commit intotigera:masterfrom Mar 13, 2026
Merged
Fix sync-versions GHA for older release branches#4545caseydavenport merged 1 commit intotigera:masterfrom
caseydavenport merged 1 commit intotigera:masterfrom
Conversation
The GIT_CLONE_URL_BASE variable only exists on master, so passing it on the command line has no effect on older release branches where the SSH URL is hardcoded. Use git's insteadOf config to rewrite SSH URLs to HTTPS at the git level, which works regardless of the Makefile version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4544 — the
GIT_CLONE_URL_BASEvariable only exists on master, so passing it on the make command line has no effect on older release branches where the SSH URL is hardcoded in thefetch_crdsfunction. This was causingrelease-v1.38(and likely other older branches) to fail with SSH auth errors.Adds a git
insteadOfconfig to rewritegit@github.com:URLs tohttps://github.com/at the git level, which works regardless of which branch's Makefile is checked out.