fix(logstorage): validate replicas < node count to prevent ILM stall [release-v1.38]#4556
Merged
rene-dekker merged 4 commits intotigera:release-v1.38from Mar 16, 2026
Conversation
On single-node ES clusters with replicas: 1, replica shards can never be allocated. This causes the ILM warm phase migrate action to wait indefinitely for shard copies to become active, blocking progression to the delete phase and causing indices to accumulate beyond retention. Add validation in the LogStorage initializer that rejects configurations where indices.replicas >= nodes.count, with a clear error message guiding users to set replicas to 0 for single-node deployments.
Fixes ST1008 staticcheck violation by swapping return order from (error, string) to (string, error) in validateLogStorage and validateReplicasForNodeCount. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rene-dekker
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick from master branch of the following fixes:
replicas >= nodeCount, preventing silent ILM failures.nodeCount == replicas + 1, since this leaves no headroom for node failures.Test plan
make ut UT_DIR=./pkg/controller/logstorage)replicas >= nodeCountnodeCount == replicas + 1nodeCount > replicas + 1🤖 Generated with Claude Code
Release Note