revert: remove logstorage validation warning message#4574
Merged
rene-dekker merged 1 commit intotigera:masterfrom Mar 19, 2026
Merged
revert: remove logstorage validation warning message#4574rene-dekker merged 1 commit intotigera:masterfrom
rene-dekker merged 1 commit intotigera:masterfrom
Conversation
Remove the warning log when LogStorage node count only exceeds replicas by 1. The error validation (replicas >= nodeCount) is preserved. This reverts the warning portion of PR tigera#4529. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tianfeng92
force-pushed
the
revert-logstorage-validation-msg
branch
from
b7eac13 to
0fd78b5
Compare
rene-dekker
approved these changes
Mar 19, 2026
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.nodes.countonly exceedsspec.indices.replicasby 1replicas >= nodeCount) added in feat(logstorage): validate replicas < node count to prevent ILM stall #4529 is preservedvalidateReplicasForNodeCountandvalidateLogStoragesignatures to return onlyerrorRelease Note
Test plan
make ut UT_DIR=./pkg/controller/logstorage/initializer)🤖 Generated with Claude Code