Skip to content

[release-v1.2] Add clusterrole for authenticationreviews#595

Merged
tmjd merged 1 commit into
tigera:release-v1.2from
rene-dekker:v1.2-saas-871
May 29, 2020
Merged

[release-v1.2] Add clusterrole for authenticationreviews#595
tmjd merged 1 commit into
tigera:release-v1.2from
rene-dekker:v1.2-saas-871

Conversation

@rene-dekker
Copy link
Copy Markdown
Member

@rene-dekker rene-dekker commented May 28, 2020

Add clusterrole additions for authenticationreviews such that ui users can be authenticated by es-proxy and compliance.

AuthenticationReviews is a new api in the tigera-apiserver that exchanges the auth header for userinfo. This works for basic, token, oidc and it built to circumvent a bug that is present in k8s versions lower than 1,18 when the oidc audiences flag is used, see kubernetes/kubernetes#87612

Copy link
Copy Markdown
Contributor

@doublek doublek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good for user roles. Note that there are no corresponding backend CRDs as it's only an apiserver endpoint and hence no other RBAC change in this PR.

@tmjd tmjd added this to the v1.2.9 milestone May 29, 2020
@tmjd tmjd added enterprise Feature applies to enterprise only kind/enhancement New feature or request labels May 29, 2020
Copy link
Copy Markdown
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmjd tmjd merged commit aa8658a into tigera:release-v1.2 May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enterprise Feature applies to enterprise only kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants