To merge 3.11.1-dev to 3.11 base #648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOC-2391 feat(backup): cloud-specific configuration parameters;
victorleeTG
reviewed
Dec 10, 2024
| |System.Backup.S3.AWSAccessKeyID |The access key for the cloud storage bucket. For AWS, the S3 access key ID; for GCS, the "Access Key". For Azure, the blob "Account Name". | `null` | ||
| |System.Backup.S3.Enable |Enables or disables backup to AWS S3 or S3-compatible services such as Ceph S3.|`false` | ||
|
|
||
| |System.Backup.S3.AWSAccessKeyID |AWS Access Key ID for authentication (deprecated, use System.Backup.S3.AccessKeyID instead, which has a higher priority.) | `null` |
Collaborator
There was a problem hiding this comment.
@anjaliIthapeTG The release notes page has a list of deprecations. Can you add these there? You can do that in a separate PR; it's not urgent.
|
|
||
| .Users should configure this parameter *only* for special cases, such as: | ||
| * To backup to a private AWS S3, typically set it to "https://s3.amazonaws.com/" or any available URI. | ||
| * To backup to a AWS S3 vpc endpoint, typically set it to "https://s3.amazonaws.com/" or any available URI/VPC endpoints. |
Collaborator
There was a problem hiding this comment.
@anjaliIthapeTG "vpc" is a acronym, so it should be capitalized. You can fix this later.
victorleeTG
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.