Fix shared route bindings mutation in _substituteBindings#875
Merged
bakerkretzmar merged 2 commits intotighten:2.xfrom Mar 5, 2026
Merged
Fix shared route bindings mutation in _substituteBindings#875bakerkretzmar merged 2 commits intotighten:2.xfrom
bakerkretzmar merged 2 commits intotighten:2.xfrom
Conversation
When a route parameter object was missing its registered binding key but had an 'id' key, _substituteBindings would set `bindings[key] = 'id'` directly on the shared route definition. This permanently changed the binding for all subsequent calls to that route. Use a local variable instead so the fallback to 'id' is resolved per call without mutating the route config.
Collaborator
|
Wow great catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
_substituteBindingsencounters an object missing its registered binding key (e.g.slug), it falls back toid— but it does so by writingbindings[key] = 'id'directly on the shared route definition. This permanently overwrites the original binding for all subsequent calls.For example, with a
posts.showroute bound toslug:The second call uses
idinstead ofslugbecause the first call mutated the route config.This PR replaces the mutation with a local variable so the fallback is resolved per-call.