feat: produce single executable binary#18
Open
rtorresware wants to merge 1 commit intotigrisdata:mainfrom
Open
feat: produce single executable binary#18rtorresware wants to merge 1 commit intotigrisdata:mainfrom
rtorresware wants to merge 1 commit intotigrisdata:mainfrom
Conversation
Collaborator
|
Thanks for the PR @rtorresware. As I mentioned in the original issue, our current focus at the moment is to add missing features. |
|
@rtorresware thanks for the contribution. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
462a461 to
123fd00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage bun to produce a single executable binary.
The registry pattern was used so bun could know the code at compile time (required for a single executable binary).
A big portion of the code additions is the
bun.lockfile.Note
Medium Risk
Medium risk because it changes core CLI command resolution/loading and build-time asset handling; missing/incorrect registry entries or YAML loader differences could make commands/specs unavailable at runtime.
Overview
Refactors command discovery/loading to be compile-time resolvable by replacing filesystem existence checks and dynamic
import()path probing with a centralized staticsrc/lib/registry.ts(getModule/hasModule).Changes spec loading to import
specs.yamldirectly (with a new*.yamlTS module declaration) and updatestsup/esbuild to load.yamlas text instead of copying the file post-build. Adds the generatedbun.locklockfile to support Bun-based builds.Written by Cursor Bugbot for commit 123fd00. This will update automatically on new commits. Configure here.