fix: always show pagination token when more results exist#76
Merged
designcode merged 6 commits intomainfrom Apr 8, 2026
Merged
fix: always show pagination token when more results exist#76designcode merged 6 commits intomainfrom
designcode merged 6 commits intomainfrom
Conversation
Remove the isPaginated gate from output decisions. The pagination token and hint are now shown whenever the response indicates more items exist, regardless of whether --limit or --page-token were explicitly passed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The ls command also uses list() and listBuckets() from the SDK but was missing pagination flags and token display. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Always use formatPaginatedOutput so JSON output is consistently
{ "items": [...] } with optional paginationToken, rather than switching
between a bare array and wrapped object based on server response.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The storage SDK now supports pagination in listBucketSnapshots. Update the snapshots list command to accept --limit and --page-token flags and display the pagination token when more results exist. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The updated @tigrisdata/storage SDK replaced hasForks and sourceBucketName with forkInfo.hasChildren and forkInfo.parents[]. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32ee29a. Configure here.
tahakhan
approved these changes
Apr 8, 2026
|
🎉 This PR is included in version 2.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isPaginatedgate from pagination output — the token and stderr hint now appear whenever the server returns more results, even without--limit/--page-tokentigris objects list, you'll see the pagination token instead of silently truncatingTest plan
npm run buildandnpm testpass (542 tests)tigris objects list 1760458746418 --prefix test/— shows token hint without--limittigris objects list 1760458746418 --prefix test/ --limit 5— still works as before🤖 Generated with Claude Code
Note
Medium Risk
Behavior changes across multiple listing commands and upgrades
@tigrisdata/storageto a new major version, which could subtly affect pagination and fork/snapshot response shapes.Overview
This PR makes list-style commands always use
formatPaginatedOutputand always print theprintPaginationHintwhen the backend returns apaginationToken, even if the user did not pass--limit/--page-token(e.g.,ls,objects list,access-keys list,iam policies list,buckets list,snapshots list).It updates bucket fork detection to match the new storage API shape (using
forkInfo.hasChildren/forkInfo.parentsinstead ofhasForks/sourceBucketName) and updatessnapshots listto the new paginated response structure. CLI specs are extended to document--limit/--page-tokenforlsandsnapshots list, and@tigrisdata/storageis bumped to^3.0.0.Reviewed by Cursor Bugbot for commit 32ee29a. Bugbot is set up for automated code reviews on this repo. Configure here.