-
Notifications
You must be signed in to change notification settings - Fork 1
feat(iam): add key rotation and enhances policy management #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
50a4bdd
feat(iam): implement rotate access key
designcode ad00fc9
fix(iam): pagination marker for list keys and policies
designcode 8367adb
feat(iam): implement key to policy methods
designcode e1979aa
fix(iam): getPolicy user output
designcode aba9131
fix(iam): add safety checks for rotate response and pagination token
designcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| import { createIAMClient, IAM_ENDPOINTS } from '../http-client'; | ||
| import { TigrisIAMConfig, TigrisIAMResponse } from '../types'; | ||
|
|
||
| export type AttachPolicyToAccessKeyOptions = { | ||
| config?: TigrisIAMConfig; | ||
| }; | ||
|
|
||
| export async function attachPolicyToAccessKey( | ||
| accessKeyId: string, | ||
| policyArn: string, | ||
| options?: AttachPolicyToAccessKeyOptions | ||
| ): Promise<TigrisIAMResponse<void, Error>> { | ||
| const { data: client, error } = createIAMClient(options?.config); | ||
| if (error) { | ||
| return { error }; | ||
| } | ||
|
|
||
| const formData = new URLSearchParams(); | ||
| formData.append('PolicyArn', policyArn); | ||
| formData.append('UserName', accessKeyId); | ||
|
|
||
| const headers = { | ||
| 'Content-Type': 'application/x-www-form-urlencoded', | ||
| Accept: 'application/json', | ||
| }; | ||
|
|
||
| const response = await client.request<URLSearchParams, unknown>({ | ||
| method: 'POST', | ||
| path: IAM_ENDPOINTS.attachPolicy, | ||
| body: formData, | ||
| headers, | ||
| }); | ||
|
|
||
| if (response.error) { | ||
| return { error: response.error }; | ||
| } | ||
|
|
||
| return { data: undefined }; | ||
| } | ||
|
|
||
| export type DetachPolicyFromAccessKeyOptions = { | ||
| config?: TigrisIAMConfig; | ||
| }; | ||
|
|
||
| export async function detachPolicyFromAccessKey( | ||
| accessKeyId: string, | ||
| policyArn: string, | ||
| options?: DetachPolicyFromAccessKeyOptions | ||
| ): Promise<TigrisIAMResponse<void, Error>> { | ||
| const { data: client, error } = createIAMClient(options?.config); | ||
| if (error) { | ||
| return { error }; | ||
| } | ||
|
|
||
| const formData = new URLSearchParams(); | ||
| formData.append('PolicyArn', policyArn); | ||
| formData.append('UserName', accessKeyId); | ||
|
|
||
| const headers = { | ||
| 'Content-Type': 'application/x-www-form-urlencoded', | ||
| Accept: 'application/json', | ||
| }; | ||
|
|
||
| const response = await client.request<URLSearchParams, unknown>({ | ||
| method: 'POST', | ||
| path: IAM_ENDPOINTS.detachPolicy, | ||
| body: formData, | ||
| headers, | ||
| }); | ||
|
|
||
| if (response.error) { | ||
| return { error: response.error }; | ||
| } | ||
|
|
||
| return { data: undefined }; | ||
| } | ||
|
|
||
| export type ListPoliciesForAccessKeyOptions = { | ||
| config?: TigrisIAMConfig; | ||
| paginationToken?: string; | ||
| limit?: number; | ||
| }; | ||
|
|
||
| export type ListPoliciesForAccessKeyResponse = { | ||
| paginationToken?: string; | ||
| policies: string[]; // policy names | ||
| }; | ||
|
|
||
| type ListPoliciesForAccessKeyApiResponse = { | ||
| ListUserPoliciesResult: { | ||
| IsTruncated: boolean; | ||
| Marker: string; | ||
| PolicyNames: string[]; | ||
| }; | ||
| }; | ||
|
|
||
| export async function listPoliciesForAccessKey( | ||
| accessKeyId: string, | ||
| options?: ListPoliciesForAccessKeyOptions | ||
| ): Promise<TigrisIAMResponse<ListPoliciesForAccessKeyResponse, Error>> { | ||
| const { data: client, error } = createIAMClient(options?.config); | ||
| if (error) { | ||
| return { error }; | ||
| } | ||
|
|
||
| const formData = new URLSearchParams(); | ||
| formData.append('UserName', accessKeyId); | ||
| formData.append('MaxItems', options?.limit?.toString() ?? '1000'); | ||
| if (options?.paginationToken) { | ||
| formData.append('Marker', options.paginationToken); | ||
| } | ||
|
|
||
| const headers = { | ||
| 'Content-Type': 'application/x-www-form-urlencoded', | ||
| Accept: 'application/json', | ||
| }; | ||
|
|
||
| const response = await client.request< | ||
| URLSearchParams, | ||
| ListPoliciesForAccessKeyApiResponse | ||
| >({ | ||
| method: 'POST', | ||
| path: IAM_ENDPOINTS.listPoliciesForAccessKey, | ||
| body: formData, | ||
| headers, | ||
| }); | ||
|
|
||
| if (response.error) { | ||
| return { error: response.error }; | ||
| } | ||
|
|
||
| return { | ||
| data: { | ||
| paginationToken: response.data.ListUserPoliciesResult.IsTruncated | ||
| ? response.data.ListUserPoliciesResult.Marker || undefined | ||
| : undefined, | ||
| policies: response.data.ListUserPoliciesResult.PolicyNames ?? [], | ||
| }, | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { createIAMClient, IAM_ENDPOINTS } from '../http-client'; | ||
| import { TigrisIAMConfig, TigrisIAMResponse } from '../types'; | ||
|
|
||
| export type RotateAccessKeyOptions = { | ||
| config?: TigrisIAMConfig; | ||
| }; | ||
|
|
||
| export type RotateAccessKeyResponse = { | ||
| id: string; | ||
| newSecret: string; | ||
| }; | ||
|
|
||
| type IAMRotateAccessKeyResponse = { | ||
| message: string; | ||
| rotate_access_key_result: { | ||
| id: string; | ||
| new_secret: string; | ||
| }; | ||
| status: string; | ||
| }; | ||
|
|
||
| export async function rotateAccessKey( | ||
| accessKeyId: string, | ||
| options?: RotateAccessKeyOptions | ||
| ): Promise<TigrisIAMResponse<RotateAccessKeyResponse, Error>> { | ||
| const { data: client, error } = createIAMClient(options?.config); | ||
| if (error) { | ||
| return { error }; | ||
| } | ||
|
|
||
| const formData = new URLSearchParams(); | ||
| formData.append('Action', 'RotateAccessKey'); | ||
|
designcode marked this conversation as resolved.
|
||
| formData.append('AccessKeyId', accessKeyId); | ||
|
|
||
| const headers = { | ||
| 'Content-Type': 'application/x-www-form-urlencoded', | ||
| Accept: 'application/json', | ||
| }; | ||
|
|
||
| const response = await client.request< | ||
| URLSearchParams, | ||
| IAMRotateAccessKeyResponse | ||
| >({ | ||
| method: 'POST', | ||
| path: IAM_ENDPOINTS.rotateAccessKey, | ||
| body: formData, | ||
| headers, | ||
| }); | ||
|
|
||
| if (response.error || response.data?.status !== 'success') { | ||
| return { | ||
| error: | ||
| response.error ?? | ||
| new Error(response.data?.message ?? 'Unable to rotate access key'), | ||
| }; | ||
| } | ||
|
|
||
| const id = response.data?.rotate_access_key_result?.id; | ||
| const newSecret = response.data?.rotate_access_key_result?.new_secret; | ||
|
|
||
| if (!id || !newSecret) { | ||
| return { | ||
| error: new Error('Invalid response: missing access key id or secret'), | ||
| }; | ||
| } | ||
|
|
||
| return { data: { id, newSecret } }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.