Skip to content

config: increase default RUScale from 1.40 to 2.10#1950

Merged
disksing merged 2 commits intotikv:masterfrom
oh-my-tidb:feature/ru-scale-default-2.10
Apr 23, 2026
Merged

config: increase default RUScale from 1.40 to 2.10#1950
disksing merged 2 commits intotikv:masterfrom
oh-my-tidb:feature/ru-scale-default-2.10

Conversation

@disksing
Copy link
Copy Markdown
Collaborator

@disksing disksing commented Apr 23, 2026

Increase the default RUScale factor from 1.40 to 2.10 (1.5x) to adjust TiKV-side RU v2 calculation.

Summary by CodeRabbit

  • Configuration Updates
    • Updated RU v2 TiKV weight scaling to improve accuracy of resource consumption metrics and capacity planning. Recalibration ensures more precise performance tracking and billing calculations for database operations.

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot Bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Apr 23, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

📝 Walkthrough

Walkthrough

This PR updates the default RU v2 TiKV weight configuration by changing the RUScale constant from 1.40 to 2.10 in the DefaultRUV2TiKVConfig() function.

Changes

Cohort / File(s) Summary
RU v2 Configuration
config/client.go
Updated RUScale constant in DefaultRUV2TiKVConfig() from 1.40 to 2.10.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

lgtm, approved, size/XS

Suggested reviewers

  • nolouch
  • ekexium
  • JmPotato

Poem

🐰 A constant revised, from one-four-oh to two,
The RUScale hops along, with values fresh and new,
TiKV weights adjusted with precision so keen,
Config optimized—the best you've ever seen! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: updating the default RUScale configuration from 1.40 to 2.10.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2026
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 23, 2026
@disksing disksing changed the title feature: increase default RUScale from 1.40 to 2.10 config: increase default RUScale from 1.40 to 2.10 Apr 23, 2026
@ti-chi-bot ti-chi-bot Bot added the lgtm label Apr 23, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 23, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 23, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-23 08:49:20.574976928 +0000 UTC m=+2242165.780336985: ☑️ agreed by nolouch.
  • 2026-04-23 08:52:35.389795828 +0000 UTC m=+2242360.595155885: ☑️ agreed by ekexium.

@disksing disksing merged commit fce9638 into tikv:master Apr 23, 2026
13 checks passed
@disksing disksing deleted the feature/ru-scale-default-2.10 branch April 23, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants