Skip to content

Comments

Promote @skyzh to Coprocessor committer#79

Merged
breezewish merged 1 commit intomasterfrom
qinding-cxs
Jul 31, 2020
Merged

Promote @skyzh to Coprocessor committer#79
breezewish merged 1 commit intomasterfrom
qinding-cxs

Conversation

@breezewish
Copy link
Member

@breezewish breezewish commented Jul 29, 2020

@skyzh is the most talented contributor I have seen so far in the Coprocessor SIG. This PR promotes him directly from Active Contributor to Committer in the Coprocessor SIG for his impressive and outstanding contribution for the Full Chunk based computing task, which is also a CNCF CommunityBridge project.

Highlights:

  • A huge refactor (5000+ LOC) with a well-organized and incremental style of change, PR by PR, reveals good understanding of the whole architecture and technical details.
  • Almost in the right and nice direction all the time -- I left only very few comments to request for change for his refactoring work.

A list of all PRs he has worked with.

@breezewish breezewish requested a review from a team July 29, 2020 14:49
Signed-off-by: Breezewish <me@breeswish.org>
@AndreMouche AndreMouche requested a review from a team July 31, 2020 03:25
@AndreMouche
Copy link
Member

@tikv/maintainers PTAL, thank you

Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Congratulations!

Copy link
Contributor

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tql

@breezewish breezewish merged commit af8d878 into master Jul 31, 2020
@breezewish breezewish deleted the qinding-cxs branch July 31, 2020 05:53
@breezewish
Copy link
Member Author

Congrats!

@skyzh
Copy link
Member

skyzh commented Jul 31, 2020

Thanks everyone! It's my honor to have such opportunity to collaborate with the TiKV community. I'm looking forward to making more contributions to the TiKV project.

@skyzh
Copy link
Member

skyzh commented Jan 19, 2021

Hi @AndreMouche , it seems that after I finished my internship, my GitHub account has been removed from TiKV organization. Would you please add me back as a community member? Thanks!

@BusyJay
Copy link
Member

BusyJay commented Jan 19, 2021

It's a mistake. Now you are added back to TiKV Org.

cfzjywxk pushed a commit to cfzjywxk/community that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants