schedule: fix panic when setting store-limit-mode to auto#2544
Merged
ti-srebot merged 1 commit intotikv:masterfrom Jun 17, 2020
Merged
schedule: fix panic when setting store-limit-mode to auto#2544ti-srebot merged 1 commit intotikv:masterfrom
ti-srebot merged 1 commit intotikv:masterfrom
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2544 +/- ##
==========================================
+ Coverage 77.11% 77.19% +0.08%
==========================================
Files 204 204
Lines 22067 22071 +4
==========================================
+ Hits 17016 17037 +21
+ Misses 3771 3753 -18
- Partials 1280 1281 +1
Continue to review full report at Codecov.
|
lhy1024
approved these changes
Jun 17, 2020
disksing
approved these changes
Jun 17, 2020
Contributor
|
/merge |
Contributor
|
/run-all-tests |
Contributor
|
cherry pick to release-3.1 failed |
Contributor
|
cherry pick to release-4.0 in PR #2547 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #2540.
What is changed and how it works?
This PR checks if the store limits of adding peer and removing peer are existed before calling
Mode.Check List
Tests
Release note
store-limit-modetoauto