Skip to content

schedule: add metrcis for region scatter (#3582)#3595

Merged
Yisaer merged 3 commits intotikv:release-4.0from
ti-srebot:release-4.0-b8c3d1445bb7
May 10, 2021
Merged

schedule: add metrcis for region scatter (#3582)#3595
Yisaer merged 3 commits intotikv:release-4.0from
ti-srebot:release-4.0-b8c3d1445bb7

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Apr 15, 2021

cherry-pick #3582 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In pd repo:
git pr https://github.com/tikv/pd/pull/3595

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/pd.git pr/3595:release-4.0-b8c3d1445bb7

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

Add metrics in region scatter

image

What is changed and how it works?

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Apr 15, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Apr 15, 2021
@ti-srebot ti-srebot added this to the v4.0.13 milestone Apr 15, 2021
@ti-chi-bot ti-chi-bot requested a review from Yisaer April 15, 2021 07:40
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@Yisaer you're already a collaborator in bot's repo.

@rleungx rleungx added type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick. and removed type/cherry-pick labels Apr 25, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 8, 2021
Yisaer added 2 commits May 10, 2021 20:57
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer
Copy link
Copy Markdown
Contributor

Yisaer commented May 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: /merge in this pull request requires 2 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2021
@Yisaer
Copy link
Copy Markdown
Contributor

Yisaer commented May 10, 2021

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2021
@Yisaer
Copy link
Copy Markdown
Contributor

Yisaer commented May 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: /merge in this pull request requires 2 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2021
@Yisaer
Copy link
Copy Markdown
Contributor

Yisaer commented May 10, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c94a0a1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 10, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2021

Codecov Report

Merging #3595 (c94a0a1) into release-4.0 (f71ab12) will decrease coverage by 0.13%.
The diff coverage is 63.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #3595      +/-   ##
===============================================
- Coverage        74.75%   74.62%   -0.14%     
===============================================
  Files              211      211              
  Lines            19880    19908      +28     
===============================================
- Hits             14861    14856       -5     
- Misses            3683     3725      +42     
+ Partials          1336     1327       -9     
Flag Coverage Δ
unittests 74.62% <63.33%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/filter/filters.go 85.09% <ø> (ø)
server/schedule/region_scatterer.go 74.75% <60.71%> (-2.53%) ⬇️
server/schedule/metrics.go 100.00% <100.00%> (ø)
server/cluster/coordinator.go 60.42% <0.00%> (-6.96%) ⬇️
server/tso/tso.go 80.43% <0.00%> (-3.63%) ⬇️
server/member/lease.go 91.07% <0.00%> (-3.58%) ⬇️
pkg/etcdutil/etcdutil.go 77.94% <0.00%> (-2.95%) ⬇️
server/kv/etcd_kv.go 78.26% <0.00%> (-1.45%) ⬇️
server/member/leader.go 67.43% <0.00%> (-1.38%) ⬇️
client/client.go 69.54% <0.00%> (-0.51%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71ab12...c94a0a1. Read the comment docs.

@Yisaer Yisaer merged commit 6b1f8ab into tikv:release-4.0 May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 The PR belongs to release-4.0 cherry pick.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants