Skip to content

schedule: add metrcis for region scatter (#3582)#3596

Merged
Yisaer merged 3 commits intotikv:release-5.0from
ti-srebot:release-5.0-b8c3d1445bb7
Apr 16, 2021
Merged

schedule: add metrcis for region scatter (#3582)#3596
Yisaer merged 3 commits intotikv:release-5.0from
ti-srebot:release-5.0-b8c3d1445bb7

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Apr 15, 2021

cherry-pick #3582 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In pd repo:
git pr https://github.com/tikv/pd/pull/3596

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/pd.git pr/3596:release-5.0-b8c3d1445bb7

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

Add metrics in region scatter

image

What is changed and how it works?

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Apr 15, 2021
@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Apr 15, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 15, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@Yisaer you're already a collaborator in bot's repo.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2021

Codecov Report

Merging #3596 (228a48c) into release-5.0 (a811014) will increase coverage by 0.07%.
The diff coverage is 81.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #3596      +/-   ##
===============================================
+ Coverage        74.49%   74.57%   +0.07%     
===============================================
  Files              245      245              
  Lines            24094    24122      +28     
===============================================
+ Hits             17950    17988      +38     
+ Misses            4526     4519       -7     
+ Partials          1618     1615       -3     
Flag Coverage Δ
unittests 74.57% <81.81%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/region_scatterer.go 87.04% <80.00%> (-1.58%) ⬇️
server/schedule/filter/filters.go 90.76% <100.00%> (ø)
server/schedule/metrics.go 100.00% <100.00%> (ø)
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/schedulers/utils.go 93.10% <0.00%> (-1.38%) ⬇️
server/core/storage.go 67.68% <0.00%> (-0.77%) ⬇️
server/cluster/cluster.go 82.92% <0.00%> (-0.49%) ⬇️
server/grpc_service.go 47.62% <0.00%> (-0.23%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a811014...228a48c. Read the comment docs.

Comment thread server/schedule/region_scatterer.go Outdated
Signed-off-by: yisaer <disxiaofei@163.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
@Yisaer
Copy link
Copy Markdown
Contributor

Yisaer commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: /merge in this pull request requires 2 /lgtm.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2021
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0a8854d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Yisaer Yisaer merged commit 3dd3c7b into tikv:release-5.0 Apr 16, 2021
@Yisaer Yisaer removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants