server/leader: return error when no leader#376
Merged
huachaohuang merged 1 commit intomasterfrom Nov 4, 2016
Merged
Conversation
The get leader API does not check nil leader, it may panic when no leader. I think is more reasonable to return an error when no leader in `GetLeader()`, so we don't need to check nil leader everywhere.
Contributor
Author
|
PTAL @overvenus @siddontang |
Contributor
|
LGTM |
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Aug 6, 2025
* PD support etcd groups (tikv#375) * init commit Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * fix comment Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint' Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * rename Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * add pd-ctl support Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * fix new import path Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * fix test package path Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com>
bufferflies
pushed a commit
to bufferflies/pd
that referenced
this pull request
Apr 14, 2026
* PD support etcd groups (tikv#375) * init commit Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * fix comment Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint' Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * rename Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * add pd-ctl support Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * fix new import path Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * fix test package path Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: AmoebaProtozoa <8039876+AmoebaProtozoa@users.noreply.github.com> (cherry picked from commit 45bc455)
bufferflies
pushed a commit
to bufferflies/pd
that referenced
this pull request
Apr 14, 2026
* PD support etcd groups (tikv#375) * init commit Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * fix comment Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * lint' Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * rename Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * add pd-ctl support Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * fix new import path Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * fix test package path Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> * lint Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> --------- Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com> (cherry picked from commit 45bc455)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get leader API does not check nil leader, it may panic when no
leader.
I think is more reasonable to return an error when no leader in
GetLeader(), so we don't need to check nil leader everywhere.Ref: https://s3.amazonaws.com/archive.travis-ci.org/jobs/172596650/log.txt