Skip to content

Comments

*: update sys in go.mod to fix panic when using golang1.17#4058

Merged
ti-chi-bot merged 1 commit intotikv:masterfrom
hawkingrei:update_sys
Aug 31, 2021
Merged

*: update sys in go.mod to fix panic when using golang1.17#4058
ti-chi-bot merged 1 commit intotikv:masterfrom
hawkingrei:update_sys

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 31, 2021

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Without this fix running a binary can cause a panic, see upstream go issue: golang/go#45702

What is changed and how it works?

Bump x/sys so that this project supports go 1.17.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 31, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and rleungx August 31, 2021 07:26
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #4058 (57f5bd9) into master (c3c8c47) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4058      +/-   ##
==========================================
- Coverage   74.62%   74.59%   -0.03%     
==========================================
  Files         257      257              
  Lines       25972    25972              
==========================================
- Hits        19381    19375       -6     
  Misses       4867     4867              
- Partials     1724     1730       +6     
Flag Coverage Δ
unittests 74.59% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/region_syncer/client.go 77.46% <0.00%> (-4.23%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
client/base_client.go 82.29% <0.00%> (-2.61%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-2.33%) ⬇️
server/schedule/operator_controller.go 84.75% <0.00%> (-0.80%) ⬇️
server/server.go 71.58% <0.00%> (-0.76%) ⬇️
server/tso/allocator_manager.go 67.44% <0.00%> (-0.51%) ⬇️
server/grpc_service.go 47.27% <0.00%> (+0.56%) ⬆️
pkg/btree/btree.go 86.74% <0.00%> (+0.96%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c8c47...57f5bd9. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 57f5bd9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2021
@disksing disksing added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2021
@ti-chi-bot ti-chi-bot merged commit 07415f3 into tikv:master Aug 31, 2021
@hawkingrei hawkingrei deleted the update_sys branch August 31, 2021 09:18
v01dstar pushed a commit to v01dstar/pd that referenced this pull request Oct 28, 2021
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants