region_scatterer: fix the bug that could generate schedule with too few peers (#4570)

[ti-chi-bot]

This is an automated cherry-pick of #4570

What problem does this PR solve?

close #4565

What is changed and how it works?

If an originPeer is already in selectStore, continue directly. Otherwise, it will end up picking a targetPeer which is either itself or some other store that is not in the initial peer list. Since entering the select phase, it is guaranteed that it is not in the selectStore, so it is always guaranteed that the worst-case selection itself is feasible at this time. In the end, the number of peers before and after can be guaranteed to remain unchanged.

Check List

Tests

• Unit test

When not modified, the following operator may be generated:

scatter-region {rm peer: store [3]} (kind:region,leader, region:201(0,0), createAt:2022-01-13 18:24:32.375399 +0800 CST m=+0.014571751, startAt:0001-01-01 00:00:00 +0000 UTC, currentStep:0, steps:[transfer leader from store 3 to store 4, remove peer on store 3])

Code changes

Side effects

Related changes

• Need to cherry-pick to the release branch

Release note

Fix the bug that the region scatterer may generate the schedule with too few peers.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• HunDunDM
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #4577 (6877ac7) into release-5.3 (ca7666b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-5.3    #4577      +/-   ##
===============================================
+ Coverage        74.87%   74.91%   +0.03%     
===============================================
  Files              264      264              
  Lines            27281    27285       +4     
===============================================
+ Hits             20427    20440      +13     
+ Misses            5037     5034       -3     
+ Partials          1817     1811       -6     

Flag	Coverage Δ
unittests	74.91% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedule/region_scatterer.go	83.19% <100.00%> (+0.28%)	⬆️
pkg/tempurl/tempurl.go	45.00% <0.00%> (-15.00%)	⬇️
server/tso/local_allocator.go	64.86% <0.00%> (-6.76%)	⬇️
server/region_syncer/client.go	79.68% <0.00%> (-3.91%)	⬇️
server/schedulers/random_merge.go	60.00% <0.00%> (-3.34%)	⬇️
server/core/hot_region_storage.go	77.33% <0.00%> (-1.34%)	⬇️
server/config/persist_options.go	91.66% <0.00%> (-1.14%)	⬇️
server/election/leadership.go	77.31% <0.00%> (-1.04%)	⬇️
server/tso/allocator_manager.go	64.83% <0.00%> (-0.34%)	⬇️
server/server.go	72.00% <0.00%> (-0.30%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7666b...6877ac7. Read the comment docs.

[HunDunDM]

/rebuild

[JmPotato]

/merge

[ti-chi-bot]

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Details

Commit hash: 6877ac7