Skip to content

core: scoreV2 conside the extra file#5819

Merged
ti-chi-bot merged 2 commits intotikv:masterfrom
bufferflies:store_core
Jan 9, 2023
Merged

core: scoreV2 conside the extra file#5819
ti-chi-bot merged 2 commits intotikv:masterfrom
bufferflies:store_core

Conversation

@bufferflies
Copy link
Copy Markdown
Contributor

@bufferflies bufferflies commented Dec 30, 2022

Signed-off-by: bufferflies 1045931706@qq.com

What problem does this PR solve?

Issue Number: Close #5790

What is changed and how does it work?

Using used size to replace capacity - available .

Check List

Tests

  • Unit test
    master:

image

this pr:
image

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

 None.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Dec 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 30, 2022
@ti-chi-bot ti-chi-bot requested review from Yisaer and lhy1024 December 30, 2022 10:08
@bufferflies bufferflies requested review from rleungx and removed request for Yisaer December 30, 2022 10:10
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2022

Codecov Report

Base: 75.50% // Head: 75.57% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (c87c44f) compared to base (f18aef7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5819      +/-   ##
==========================================
+ Coverage   75.50%   75.57%   +0.07%     
==========================================
  Files         338      338              
  Lines       33603    33606       +3     
==========================================
+ Hits        25373    25399      +26     
+ Misses       6044     6033      -11     
+ Partials     2186     2174      -12     
Flag Coverage Δ
unittests 75.57% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/store.go 80.47% <100.00%> (+0.07%) ⬆️
server/core/test_util.go 83.46% <100.00%> (+0.26%) ⬆️
pkg/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/storage/storage.go 67.30% <0.00%> (-3.85%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-3.13%) ⬇️
server/schedulers/shuffle_hot_region.go 55.12% <0.00%> (-2.57%) ⬇️
pkg/storage/endpoint/meta.go 61.36% <0.00%> (-2.28%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/config/persist_options.go 92.18% <0.00%> (-0.98%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bufferflies bufferflies force-pushed the store_core branch 3 times, most recently from 2a0c356 to cac14cf Compare January 3, 2023 07:16
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Jan 3, 2023
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 9, 2023
Copy link
Copy Markdown
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 9, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Jan 9, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9a2282f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 9, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

@bufferflies: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 74136a9 into tikv:master Jan 9, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #5841.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 9, 2023
close tikv#5790

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #5842.

ti-chi-bot added a commit that referenced this pull request Jan 11, 2023
* This is an automated cherry-pick of #5819

close #5790

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* resolve conflict

Signed-off-by: bufferflies <1045931706@qq.com>

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: bufferflies <1045931706@qq.com>
Co-authored-by: buffer <1045931706@qq.com>
ti-chi-bot added a commit that referenced this pull request Jan 12, 2023
Signed-off-by: bufferflies <1045931706@qq.com>

Signed-off-by: bufferflies <1045931706@qq.com>
Co-authored-by: bufferflies <1045931706@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Balance region scheduler doesn't work as expected

4 participants