keyspace: add region label when creating keyspace#5844
keyspace: add region label when creating keyspace#5844disksing merged 17 commits intotikv:masterfrom
Conversation
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
# Conflicts: # pkg/storage/kv/etcd_kv.go # pkg/storage/kv/levedb_kv.go
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
Hi @AmoebaProtozoa. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 74.96% // Head: 74.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5844 +/- ##
==========================================
- Coverage 74.96% 74.94% -0.02%
==========================================
Files 337 337
Lines 34065 34116 +51
==========================================
+ Hits 25536 25569 +33
- Misses 6341 6353 +12
- Partials 2188 2194 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: b43b58b |
|
@AmoebaProtozoa: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/test build |
What problem does this PR solve?
Issue Number: Ref #5293
When a new keyspace is being created, we also create a set of region labels to makes sure two keyspace's data will be located in different region.
What is changed and how does it work?
Check List
Tests
Release note