Skip to content

chore: update tidb-dashboard version to v2023.05.08.1#6516

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
baurine:chore/update-dashboard
May 25, 2023
Merged

chore: update tidb-dashboard version to v2023.05.08.1#6516
ti-chi-bot[bot] merged 3 commits intotikv:release-6.5from
baurine:chore/update-dashboard

Conversation

@baurine
Copy link
Copy Markdown
Contributor

@baurine baurine commented May 25, 2023

What problem does this PR solve?

Issue Number: Close #6520

Update tidb-dashboard to the lastest version, to fix pingcap/tidb-dashboard#1515 issue in the 6.5.3 version that the clients ask for.

What is changed and how does it work?

Update tidb-dashboard to the lastest version (v2023.05.08.1)

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

Signed-off-by: baurine <2008.hbl@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 25, 2023
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2023

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot Bot requested review from HunDunDM and rleungx May 25, 2023 03:14
@baurine
Copy link
Copy Markdown
Contributor Author

baurine commented May 25, 2023

I update the tidb-dashboard by the following commands:

go get -d github.com/pingcap/tidb-dashboard@v2023.05.08.1
go mod tidy
make pd-server
go mod tidy

Not sure why other modules are changed as well.

@baurine
Copy link
Copy Markdown
Contributor Author

baurine commented May 25, 2023

/cc @nolouch @CabinfeverB PTAL, thanks~

@ti-chi-bot ti-chi-bot Bot requested review from CabinfeverB and nolouch May 25, 2023 03:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (08b8fc8) 75.75% compared to head (b5c0d5c) 75.69%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #6516      +/-   ##
===============================================
- Coverage        75.75%   75.69%   -0.07%     
===============================================
  Files              330      330              
  Lines            33072    33072              
===============================================
- Hits             25055    25033      -22     
- Misses            5870     5887      +17     
- Partials          2147     2152       +5     
Flag Coverage Δ
unittests 75.69% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: baurine <2008.hbl@gmail.com>
@baurine baurine force-pushed the chore/update-dashboard branch from ff47db4 to 361f0da Compare May 25, 2023 03:29
Copy link
Copy Markdown
Member

@CabinfeverB CabinfeverB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need to run go mod tidy with a higher version go

@CabinfeverB
Copy link
Copy Markdown
Member

Maybe you need to run go mod tidy with a higher version go

pls remove docs/swagger/docs.go

- remove swagger/docs.go and swagger/swagger.json, swagger/swagger.yaml,
run `go mod tidy`

Signed-off-by: baurine <2008.hbl@gmail.com>
@ti-chi-bot ti-chi-bot Bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023
@CabinfeverB CabinfeverB added the require-LGT1 Indicates that the PR requires an LGTM. label May 25, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 25, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented May 25, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b5c0d5c

@ti-chi-bot ti-chi-bot Bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
@CabinfeverB
Copy link
Copy Markdown
Member

/rebuild

@CabinfeverB
Copy link
Copy Markdown
Member

/run-all-tests

@purelind
Copy link
Copy Markdown
Contributor

/test build

@ti-chi-bot ti-chi-bot Bot merged commit 801601f into tikv:release-6.5 May 25, 2023
@baurine baurine deleted the chore/update-dashboard branch May 25, 2023 14:05
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants