Skip to content

fix(tests): validate whether RaftCluster is running in MustPutStore#9177

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
JmPotato:fix_MustPutStore
Apr 2, 2025
Merged

fix(tests): validate whether RaftCluster is running in MustPutStore#9177
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
JmPotato:fix_MustPutStore

Conversation

@JmPotato
Copy link
Copy Markdown
Member

@JmPotato JmPotato commented Apr 1, 2025

What problem does this PR solve?

Issue Number: close #9176.

What is changed and how does it work?

Improve robustness of `MustPutStore` by validating `RaftCluster` is running.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato added the component/testing CI testing. label Apr 1, 2025
@JmPotato JmPotato requested review from okJiang and rleungx April 1, 2025 13:51
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (411bd25) to head (95ecd1d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9177      +/-   ##
==========================================
+ Coverage   75.69%   75.81%   +0.12%     
==========================================
  Files         476      476              
  Lines       73110    73149      +39     
==========================================
+ Hits        55339    55458     +119     
+ Misses      14307    14231      -76     
+ Partials     3464     3460       -4     
Flag Coverage Δ
unittests 75.81% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 2, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 2, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Apr 2, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-02 02:05:38.853751662 +0000 UTC m=+1617232.537987742: ☑️ agreed by bufferflies.
  • 2025-04-02 02:49:49.254191639 +0000 UTC m=+1619882.938427734: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 7b5d47d into tikv:master Apr 2, 2025
26 checks passed
@JmPotato JmPotato deleted the fix_MustPutStore branch April 2, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component/testing CI testing. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic during TestPreparingProgress

3 participants