-
Notifications
You must be signed in to change notification settings - Fork 753
client: expose new api to cancel scheduler job #9239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9239 +/- ##
==========================================
+ Coverage 75.96% 76.03% +0.07%
==========================================
Files 472 472
Lines 73249 73256 +7
==========================================
+ Hits 55646 55703 +57
+ Misses 14131 14099 -32
+ Partials 3472 3454 -18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: 童剑 <1045931706@qq.com>
92239c0 to
c6c2ad7
Compare
Signed-off-by: 童剑 <1045931706@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new API to cancel scheduler jobs in PD and updates the client and integration tests accordingly.
- Introduces CancelSchedulerJob as a new method in the client interface and its implementation.
- Adds a URI generator function for the cancel operation in the API layer.
- Updates integration tests to verify that the scheduler job cancellation behaves as expected.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integrations/client/http_client_test.go | Updates to test job cancellation behavior |
| client/http/request_info.go | Added constant for cancel scheduler job request |
| client/http/interface.go | Introduced method and implementation for canceling a scheduler job |
| client/http/api.go | Added URI function for cancel scheduler job |
Comments suppressed due to low confidence (1)
tests/integrations/client/http_client_test.go:615
- [nitpick] Consider renaming 'checkFn' to a more descriptive name such as 'getJobDetails' to improve test readability.
checkFn := func() map[string]any {
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #9285
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note