Fixed some bugs#1
Open
homesick94 wants to merge 2 commits intotilast:masterfrom
Open
Conversation
tilast
requested changes
Nov 25, 2016
Owner
tilast
left a comment
tilast
left a comment
There was a problem hiding this comment.
thanks a lot, @homesick94, looks cool
you can add some compilations instructions readme as well
| //float length = x2 - x1; - unused variable | ||
|
|
||
| float c = delta / length; | ||
| //float c = delta / length; - unused variable |
Owner
There was a problem hiding this comment.
you can just remove them if they are unused
| @@ -0,0 +1,255 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| selected = NULL; | ||
| transformation = NONE; | ||
| if (!shapes.size ()) | ||
| return; |
Owner
There was a problem hiding this comment.
this condition looks to do not have any sense b/c there will not be any loop if size is 0
Author
|
Hi!
File me_shocked.pro.user.2.7pre1 has no use in this project, it is just qt
things :) So probably should have added it to .gitignore list. And In
canvaswidget - you are right, it makes no sense. Happy coding!
2016-11-26 2:41 GMT+03:00 Ihor Kroosh <notifications@github.com>:
… ***@***.**** requested changes on this pull request.
thanks a lot, @homesick94 <https://github.com/homesick94>, looks cool
you can add some compilations instructions readme as well
------------------------------
In svgfigureparser.cpp
<#1 (review)>:
>
- float c = delta / length;
+ //float c = delta / length; - unused variable
you can just remove them if they are unused
------------------------------
In me_shocked.pro.user.2.7pre1
<#1 (review)>:
> @@ -0,0 +1,255 @@
+<?xml version="1.0" encoding="UTF-8"?>
what is this file for?
------------------------------
In canvaswidget.cpp
<#1 (review)>:
> @@ -130,12 +130,16 @@ void CanvasWidget::mousePressEvent(QMouseEvent *event) {
selected = NULL;
transformation = NONE;
+ if (!shapes.size ())
+ return;
this condition looks to do not have any sense b/c there will not be any
loop if size is 0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARw_IAe23J011b9wCiS4qW62chvb7dy8ks5rB3IbgaJpZM4K6em9>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed compilation bugs and some errors, found with the help of clang static analyzer.