fix(tui): route all ACP tools through ClientToolCell, fix rendering bugs#420
Merged
fix(tui): route all ACP tools through ClientToolCell, fix rendering bugs#420
Conversation
ClientToolCell::render_edit_lines was applying prefix_lines on diff content that create_diff_summary already indented, producing 8-space indent instead of 4. Unified Move/Edit/Delete header promotion and removed the redundant wrapping. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
Read/Search tools now auto-detect as exploring in display_lines via is_exploring_snapshot(), rendering as "Explored" instead of falling to the generic "Tool [completed]" format. Execute tools get a dedicated transcript renderer using shell-style "$ command" format. The exec-like adaptation path that converted Read/Search into fake ExecCommandBegin/End events is removed (-29 lines net). 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
- Collapse handle_client_tool_snapshot wrapper into single method - Merge second impl ClientToolCell block into the first - Use .dim() Stylize helper instead of Style::default().add_modifier() - Add comment explaining why all merged exploring call_ids are tracked 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
The ACP protocol sends tool_call events in two phases: first a pending event with title "Read File" and no path, then a tool_call_update with the real path/query. apply_snapshot was updating the primary snapshot but not the exploring_snapshots vec, so exploring cells displayed stale titles like "Read Read File" instead of "Read hello.txt". - apply_snapshot now propagates updates into exploring_snapshots - Deferred completed_client_tool_calls tracking from merge-time to flush-time (via flush_active_cell) so non-terminal updates aren't blocked - flush_active_cell tracks all exploring group call_ids on flush 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
CSRessel
added a commit
that referenced
this pull request
Apr 5, 2026
…nding Replace the dead `task_complete_pending: bool` field with `session_phase: SessionPhaseView` on ChatWidget. The phase is updated from TurnLifecycle events: - Started → Prompt - Completed → Idle - Cancelling → Cancelling - Aborted/finalize_turn → Idle This is the first step toward removing the duplicated turn-state tracking between TUI and backend. The old `is_task_running` flag on BottomPane remains for now (it controls UI rendering details); the new `session_phase` field is the backend-authoritative source of truth. Also fix owner_request_id in 5 ToolSnapshot constructors from #420 merge. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
display_linesviais_exploring_snapshot()instead of falling to generic "Tool [completed]" format$ commandintranscript_lines; exploring cells use "Explored" format (previously swapped)ClientToolCellnatively, removing the exec-like adaptation path that converted Read/Search into fakeExecCommandBegin/Endevents (-29 lines net)Test Plan
Share Nori with your team: https://www.npmjs.com/package/nori-skillsets