refactor: Cut dead code paths#438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/rolloutand/test-approvalslash commands from the TUI command surface and their dead handlers/testslogin_statusandauth_managerfields from the Nori onboarding args so the Nori path only carries live datacodex-rs/tui/docs.mdso it documents the Nori update path that actually ships innoriWhy
This PR is a dead-code cleanup pass focused on the ACP-backed Nori CLI. It removes compatibility baggage and uncompiled upstream leftovers from
nori-tui, which keeps the branch net-negative and reduces accidental complexity in the code that matters for thenoribinary.Validation
RUSTC_WRAPPER= cargo test -p nori-tui --manifest-path codex-rs/Cargo.tomlRUSTC_WRAPPER= cargo build --bin nori --manifest-path codex-rs/Cargo.tomlRUSTC_WRAPPER= cargo test -p tui-pty-e2e --manifest-path codex-rs/Cargo.tomlRUSTC_WRAPPER= just fix -p nori-tuijust fmt./target/debug/nori --agent elizacp --skip-trust-directoryin an isolated tmux session, submittedhello, observed an ElizACP reply, and verified the prompt returned