fix(mcp): auto-OAuth on server add#446
Merged
Merged
Conversation
persist_mcp_servers wrote to disk but never updated the in-memory Config.mcp_servers, so ComputeMcpAuthStatuses read stale config and the auto-OAuth trigger never fired for newly added servers. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
"Restart to apply changes" no longer matches behavior — after syncing the in-memory config, auth status detection and auto-OAuth now apply immediately. The remaining restart requirement is specifically for the ACP agent's MCP server list, which is bound in create_session. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
persist_mcp_serversto sync in-memoryConfig.mcp_serversafter writing to disk, soComputeMcpAuthStatusessees newly added serversset_mcp_servers()setter onChatWidgetfollowing the existing pattern ofset_approval_policy,set_vim_mode, etc.Test Plan
set_mcp_serversupdatesconfig_ref()Share Nori with your team: https://www.npmjs.com/package/nori-skillsets