Conversation
theahura
deleted the
revert-447-auto/update-acp-adapter-from-upstream-20260421-050430
branch
4 tasks
theahura
added a commit
that referenced
this pull request
Apr 21, 2026
…scope (#449) ## Summary 🤖 Generated with [Nori](https://www.npmjs.com/package/nori-ai) - Re-applies the Claude ACP adapter package rename from `@zed-industries/claude-agent-acp` (frozen at 0.23.1) to `@agentclientprotocol/claude-agent-acp` (active, latest 0.30.0) - The original upgrade (PR #447) was reverted in PR #448 due to a "Failed to create ACP session" error - Root cause investigation showed the error was transient — the new adapter v0.30.0 is fully protocol-compatible with our `agent-client-protocol-schema v0.11.6` ## Investigation Details The "Failed to create ACP session" error was traced through the full error chain (`sacp_connection.rs:507` → `spawn_and_relay.rs:59-78` → `agent.rs:273`). Manual protocol testing with v0.30.0 confirmed: - `initialize` handshake succeeds (protocol version V1 negotiation) - `session/new` request succeeds (schema fields `cwd` and `mcpServers` are correct) - `NewSessionResponse` deserializes correctly despite new fields (`modes`, `configOptions`) End-to-end TUI verification with `NORI_MANAGED_BY_NPM=1` (to force npx and the real v0.30.0 adapter) confirmed full round-trip: spawn → handshake → session → prompt → response. ## Test Plan - [x] `test_get_claude_code_config` verifies the built-in Claude config uses the new package name - [x] All 443 passing ACP crate tests still pass (14 pre-existing failures in `backend::tests::part3` are unrelated — they require a mock ACP binary) - [x] End-to-end TUI verification: built nori binary, launched via tmux with real Claude adapter v0.30.0, sent a message and received a response - [x] Clippy clean Share Nori with your team: https://www.npmjs.com/package/nori-skillsets --------- Co-authored-by: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #447