Skip to content

fix(acp): show ACP goodbye card session stats#470

Merged
CSRessel merged 5 commits into
mainfrom
plan-goodbye-card-session-stats
May 13, 2026
Merged

fix(acp): show ACP goodbye card session stats#470
CSRessel merged 5 commits into
mainfrom
plan-goodbye-card-session-stats

Conversation

@CSRessel
Copy link
Copy Markdown
Collaborator

@CSRessel CSRessel commented May 13, 2026

Summary

  • Track ACP goodbye-card stats from normalized ClientEvent data: assistant replies, completed/failed tool snapshots, skill paths, and generic Agent tool snapshots.
  • Add narrow transcript fallback for subagent names when a discovered JSONL transcript contains delegated-agent fields that are not visible as ACP tool events.
  • Document the goodbye-card stats contract and update snapshots for the corrected assistant count.

Test Plan

  • cargo test -p nori-tui
  • cargo build -p mock-acp-agent
  • cargo test -p nori-acp
  • cargo build --bin nori
  • cargo test -p tui-pty-e2e
  • RUSTC_WRAPPER= just fix -p nori-tui
  • RUSTC_WRAPPER= just fix -p nori-acp
  • tmux close-loop: launched nori --agent elizacp --skip-trust-directory inside a persistent bash tmux session, submitted hello, exited with /exit, and verified Goodbye! plus Assistant: 1 on the card.

🤖 Generated with Nori

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

@CSRessel CSRessel changed the title docs: plan goodbye card session stats Fix ACP goodbye card session stats May 13, 2026
@CSRessel CSRessel changed the title Fix ACP goodbye card session stats fix(acp): show ACP goodbye card session stats May 13, 2026
@CSRessel CSRessel merged commit d6a40e3 into main May 13, 2026
3 checks passed
@CSRessel CSRessel deleted the plan-goodbye-card-session-stats branch May 13, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant