fix(acp): gate prompt summary background session on config#476
Merged
Conversation
Skip spawning the background ACP session for prompt summarization when neither the prompt_summary footer segment is enabled nor auto_worktree is active. Since both default to off, this eliminates wire protocol noise during debugging for the common case. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
Remove the prompt_summary_enabled field plumbing through AcpBackendConfig/AcpBackend/constructors/tests. Instead, load NoriConfig once at the spawn decision point on first prompt. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
prompt_summary_enabled || auto_worktree.is_enabled(), so it only spawns when something actually needs itprompt_summary_enabled: booltoAcpBackendConfigandAcpBackend, sourced fromFooterSegmentConfig.prompt_summaryprompt_summary(off by default in lean footer defaults) andauto_worktree(off by default) are false, the background session no longer spawns by default — eliminating wire protocol noise during debuggingTest Plan
cargo test -p nori-acppasses (config tests verify field plumbing)cargo test -p nori-tuipassescargo test -p tui-pty-e2epassescargo build --bin norisucceedsprompt_summary = truein config.toml and verify summary still appears in footerShare Nori with your team: https://www.npmjs.com/package/nori-skillsets