fix(ci): use dynamic matrix for macOS-on-main-only#490
Merged
Conversation
The `matrix` context is not available in job-level `if` conditions in GitHub Actions, causing "Unrecognized named-value: 'matrix'" errors. Replace the static matrix + job-level `if` with a dynamic `fromJSON` matrix that conditionally includes the macOS entry only on non-PR events. 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech> 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <contact@tilework.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unrecognized named-value: 'matrix'error inrust-ci.ymlintroduced by ci: migrate to Blacksmith runners #487matrixcontext is not available in job-levelifconditions in GitHub Actions — it's only available forname,runs-on,env, and step-level expressionsifwith a dynamicfromJSONmatrix that conditionally includes the macOS entry only on non-PR eventsWhat changed
Before (broken):
After (fixed):
Same behavior: PRs get Linux-only CI, pushes to main get both Linux + macOS.
Test plan