feat: Add structured tracing to ACP runner for debugging#52
Merged
Conversation
- Enable file logging via tuicore's `.use_disk_logs(true)` - Add tracing instrumentation throughout ACP lifecycle in acp_runner.rs - Use info! for key events, debug! for details, warn! for errors - Logs written to ~/.nori-cli/logs/ with daily rotation - Fix pre-existing test in model_backend_ordering_test.rs - Add tracing-subscriber as dev dependency All tests passing (107 tests, 0 failures). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.use_disk_logs(true)configuration~/.nori-cli/logs/with automatic daily rotationmodel_backend_ordering_test.rsChanges
src/main.rs: Enabled disk logs in TuiApp builder
src/acp_runner.rs: Added ~15 tracing calls covering:
tests/model_backend_ordering_test.rs: Fixed test to use
BACKEND_OPTIONSconstantTest Plan
~/.nori-cli/logs/🤖 Generated with Claude Code