Skip to content

Enable Shapely speedups if they're available#108

Merged
iandees merged 1 commit intomasterfrom
enable-shapely-speedups
Jul 19, 2017
Merged

Enable Shapely speedups if they're available#108
iandees merged 1 commit intomasterfrom
enable-shapely-speedups

Conversation

@iandees
Copy link
Copy Markdown
Member

@iandees iandees commented Jul 18, 2017

Like tilezen/mapbox-vector-tile#91, but for tileserver.

@iandees iandees requested a review from rmarianski July 18, 2017 14:32
@iandees
Copy link
Copy Markdown
Member Author

iandees commented Jul 18, 2017

(This probably isn't required, because Shapely enables speedups by default nowadays: shapely/shapely#252)

@iandees iandees closed this Jul 18, 2017
@iandees iandees deleted the enable-shapely-speedups branch July 18, 2017 14:50
@iandees iandees removed the in review label Jul 18, 2017
@nvkelso
Copy link
Copy Markdown
Member

nvkelso commented Jul 18, 2017

@iandees My reading is we're using 1.4.3 and speedups weren't enabled by default until 1.6a1

@iandees iandees restored the enable-shapely-speedups branch July 18, 2017 21:22
@iandees iandees reopened this Jul 18, 2017
@nvkelso
Copy link
Copy Markdown
Member

nvkelso commented Jul 18, 2017

LGTM, but let's get an review from @rmarianski before merging.

@rmarianski
Copy link
Copy Markdown
Member

My reading is we're using 1.4.3

Unrelated to this pr, but we're pegged to older versions of several packages now, with the only reason being consistent deployments. We should try and update them all to point to the latest versions at some point.

@iandees iandees merged commit 76b1af1 into master Jul 19, 2017
@iandees iandees removed the in review label Jul 19, 2017
@iandees iandees deleted the enable-shapely-speedups branch July 19, 2017 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants