Skip to content

Conversation

@RomainMorlevat
Copy link
Contributor

@RomainMorlevat RomainMorlevat commented Nov 14, 2024

Because of the following deprecation message:

DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will be removed in Rails 8.0.
Use Ruby's built-in BasicObject instead.

I've found that it comes from this gem:

❯ ruby -rbundler/setup -e "Bundler.require"
.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/embedded_localization-1.3.0/lib/embedded_localization.rb:9:in `<top (required)>': uninitialized constant ActiveRecord (NameError)
ActiveRecord::Base.extend(EmbeddedLocalization::ActiveRecord::ActMacro)

This PR fix the issue.

tilo and others added 2 commits November 13, 2024 12:57
Because of the following deprecation message:
> DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will
> be removed in Rails 8.0.
> Use Ruby's built-in BasicObject instead.

I've found that it comes from this gem:
```sh
❯ ruby -rbundler/setup -e "Bundler.require"
.asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/embedded_localization-1.3.0/lib/embedded_localization.rb:9:in `<top (required)>': uninitialized constant ActiveRecord (NameError)

ActiveRecord::Base.extend(EmbeddedLocalization::ActiveRecord::ActMacro)
```
@tilo
Copy link
Owner

tilo commented Nov 17, 2024

Thank you, @RomainMorlevat !

Will release the updated gem soon

@codecov
Copy link

codecov bot commented Nov 17, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@tilo
Copy link
Owner

tilo commented Nov 17, 2024

@RomainMorlevat can you check your Gemfile.lock if there is perhaps an older version of active_support, and if so, can you try to run

bundle update active_support ?

ActiveSupport::ProxyObject was a class provided by Rails 3.x as a base class for proxy objects. It was used internally by ActiveSupport for various purposes, similar to Ruby's BasicObject.

Newer versions of Rails, no longer use ActiveSupport::ProxyObject

@RomainMorlevat
Copy link
Contributor Author

@tilo
I'm upgrading Rails 7.1 > 7.2. From my Gemfile.lock:

  activesupport (= 7.2.2)

Running bundle update active_support returns: "Bundler attempted to update activesupport but its version stayed the same".

@tilo
Copy link
Owner

tilo commented Nov 25, 2024

this is odd... no issues here: tilo/embedded_localization_demo#1

@tilo tilo merged commit 9a07f1b into tilo:main Nov 26, 2024
18 of 29 checks passed
@tilo
Copy link
Owner

tilo commented Nov 26, 2024

@RomainMorlevat released in version 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants