-
Notifications
You must be signed in to change notification settings - Fork 3
🩹 Fix active support proxy object deprecation #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🩹 Fix active support proxy object deprecation #14
Conversation
Because of the following deprecation message: > DEPRECATION WARNING: ActiveSupport::ProxyObject is deprecated and will > be removed in Rails 8.0. > Use Ruby's built-in BasicObject instead. I've found that it comes from this gem: ```sh ❯ ruby -rbundler/setup -e "Bundler.require" .asdf/installs/ruby/3.3.5/lib/ruby/gems/3.3.0/gems/embedded_localization-1.3.0/lib/embedded_localization.rb:9:in `<top (required)>': uninitialized constant ActiveRecord (NameError) ActiveRecord::Base.extend(EmbeddedLocalization::ActiveRecord::ActMacro) ```
|
Thank you, @RomainMorlevat ! Will release the updated gem soon |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@RomainMorlevat can you check your
Newer versions of Rails, no longer use |
|
@tilo
Running |
|
this is odd... no issues here: tilo/embedded_localization_demo#1 |
|
@RomainMorlevat released in version 1.3.1 |
Because of the following deprecation message:
I've found that it comes from this gem:
This PR fix the issue.