Skip to content

use restart_process extension#18

Merged
maiamcc merged 1 commit intomasterfrom
maiamcc/use-restart-extension
May 18, 2020
Merged

use restart_process extension#18
maiamcc merged 1 commit intomasterfrom
maiamcc/use-restart-extension

Conversation

@maiamcc
Copy link
Contributor

@maiamcc maiamcc commented May 15, 2020

hmm so I'm getting way worse performance than the strategy the guide was
using previously -- the guide on the website said with Live update,
deploy took <5s, I'm seeing 13: https://cloud.tilt.dev/snapshot/AZyI-esLnbKLWBnZRhw=

Anything I'm missing here?

@maiamcc maiamcc requested review from jazzdan and nicks May 15, 2020 23:15
@maiamcc
Copy link
Contributor Author

maiamcc commented May 15, 2020

Hmm okay after a few more runs on my branch and on master, it seems like the restart_process
extension updates at most 1s slower than master, and often less. so it doesn't seem that my extension is massively slow... Maybe my internet just sucks?

Is it worth it to re-time/re-screenshot the guides I'm changing (this one, c#, and go)? eh.

@maiamcc
Copy link
Contributor Author

maiamcc commented May 15, 2020

Docs update here: tilt-dev/tilt.build#585

@nicks
Copy link
Member

nicks commented May 18, 2020

i wouldn't bother creating new screenshots for this, but we should update the text to introduce extensions.

do you understand why the restart_process extension is so much slower? that seems concerning

@maiamcc
Copy link
Contributor Author

maiamcc commented May 18, 2020

i wouldn't bother creating new screenshots for this, but we should update the text to introduce extensions.

Yep, on it: tilt-dev/tilt.build#585

do you understand why the restart_process extension is so much slower? that seems concerning

so after some further examination, it seems like tilt up on master is just about as slow on my machine. like, restart_process is at most 1s slower and usually less. maybe just internet speed, or...? Would you mind benchmarking master vs this branch for me and seeing if you see any weird timing stuff?

@nicks
Copy link
Member

nicks commented May 18, 2020

ah, i should have been more clear about what i meant - ya, i expect the times to vary on different machines. I'm surprised that the extension is 1s slower vs master, which seems way bigger than I would have expected. do you have hypotheses on where that 1s is going?

@maiamcc
Copy link
Contributor Author

maiamcc commented May 18, 2020

okay I went back and checked again, and there actually doesn't seem to be that much difference between the timings on master vs. this branch. I think that one 13s timing I the first time I ran this was a fluke (like, on the high side of natural variance, but as likely on master as on this branch):

restart_process
- 12.3s deploy (3.11s build)
- 11. 4 (2.82)
- 11.8 (3.39)
- 11.4 (2.5)

master
- 12.2 (3.02)
- 13.2 (2.76)
- 11.9 (2.54)
- 12.02 (2.56)

@maiamcc maiamcc merged commit 937ef47 into master May 18, 2020
@maiamcc maiamcc deleted the maiamcc/use-restart-extension branch May 18, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants